Improve precision for mean, std, var, cumsum. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
np.bincount always accumulates to float64. So only cast after the division.
dcherian
changed the title
This was referenced Jul 28, 2024
dcherian
added a commit
to xarray-contrib/flox
that referenced
this pull request
Jul 31, 2024
now that ml31415/numpy-groupies#90 was merged
dcherian
added a commit
to xarray-contrib/flox
that referenced
this pull request
Jul 31, 2024
now that ml31415/numpy-groupies#90 was merged
dcherian
added a commit
to xarray-contrib/flox
that referenced
this pull request
Aug 2, 2024
* Stricter tolerance in property tests now that ml31415/numpy-groupies#90 was merged * skip float32 with cumsum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.bincount always accumulates to float64.
So only cast after the division.